This repository was archived by the owner on May 22, 2023. It is now read-only.
Backport sp-staking from polkadot-v0.9.36#190
Open
khssnv wants to merge 2 commits into
Open
Conversation
khssnv
force-pushed
the
feature/backport-sp-staking-from-polkadot-0.9.36
branch
from
eea1074 to
7cde43a
Compare
khssnv
changed the title
AndreiNavoichyk
approved these changes
Feb 27, 2023
| @@ -0,0 +1,29 @@ | |||
| [package] | |||
| name = "sp-staking-backport" | |||
There was a problem hiding this comment.
Do you see any possible issues with renaming it back to sp-staking after we reach the Substrate target version? If yes, can we somehow prevent them now?
Author
There was a problem hiding this comment.
When the version from polkadot-v0.9.36 branch reached, the sp-staking-backport crate should be removed and all references to sp-staking-backport should be replaced with sp-staking. I expect a quick and simple update.
MRamanenkau
approved these changes
Feb 27, 2023
MRamanenkau
reviewed
Feb 27, 2023
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [vNext] |
Author
There was a problem hiding this comment.
Should we keep them separated or merge them, @AndreiNavoichyk?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces
sp-staking-backportcreate withsp-stakingbackported from substrate polkadot-v0.9.36 branch.The only change applied to the original crate is a deletion of a line staking/src/lib.rs#L194 incompatible with the current version of
sp-corecreate indev-cereand not required for a purpose of the backport.